build: constraints added to linting #3533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚀 Deployed on https://pr-3533--spectrum-css.netlify.app |
File metricsSummaryTotal size: 3.22 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
build-constraints-linting
branch
2 times, most recently
from
5dee0cf to
13aae1d
Compare
castastrophe
added
size-1 XS
castastrophe
force-pushed
the
build-constraints-linting
branch
from
13aae1d to
603c775
Compare
cdransf
approved these changes
Feb 6, 2025
5t3ph
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
bumpVersionsWithWorkspaceProtocolOnlysetting from the Changeset config and downgrade theupdateInternalDependenciesfromminortopatchto ensure local dependencies stay tightly aligned.Restructure the constraints file a bit to make it more readable and ensure it is fully documented.
Apply the constraints via
lint-stagedwhenever a package.json file is updated.How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
yarn constraints: expect no changes to this because no functionality has changed. Should not get any console feedback because there are no suggested changes to the project. (@cdransf)Note: We'll have to validate the changeset update during the next release. We'll expect the next release to bump local devDependencies for all packages.
To-do list